Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant warning at the beginning of a value followed with a comma #62

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Remove redundant warning at the beginning of a value followed with a comma #62

merged 1 commit into from
Dec 12, 2024

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Dec 11, 2024 •
edited
Loading

Given:

//> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
println("Deprecation warnings should have been printed")

Before:

[warn] ./example.sc:1:19
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]                   ^
[warn] ./example.sc:1:26
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]                          ^
[warn] ./example.sc:1:28
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]                            ^
[warn] ./example.sc:1:52
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]

After:

[warn] ./example.sc:1:26
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]                          ^
[warn] ./example.sc:1:52
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]                                                    ^

@Gedochao Gedochao force-pushed the maintenance/remove-redundant-warning branch from cfb096b to 548dfb1 Compare December 11, 2024 12:46
tgodzik
tgodzik approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Gedochao Gedochao force-pushed the maintenance/remove-redundant-warning branch from 548dfb1 to 371c5c1 Compare December 11, 2024 14:39
@Gedochao Gedochao force-pushed the maintenance/remove-redundant-warning branch from 371c5c1 to 61f9e05 Compare December 11, 2024 16:30
@Gedochao
Copy link
Contributor Author

@tgodzik rebased on top of main, making sure the test reports work now

@Gedochao
Copy link
Contributor Author

@tgodzik the test reports now seem to work correctly, even for PRs from repo forks.

@Gedochao Gedochao merged commit f904a1c into VirtusLab:main Dec 12, 2024
6 checks passed
@Gedochao Gedochao deleted the maintenance/remove-redundant-warning branch December 12, 2024 08:31
@Gedochao Gedochao mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@kasiaMarek kasiaMarek Awaiting requested review from kasiaMarek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gedochao @tgodzik